From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/8] drm/i915: Rework the FBC interval/stall stuff a bit Date: Thu, 12 Dec 2013 16:03:17 +0100 Message-ID: <20131212150317.GM9804@phenom.ffwll.local> References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com> <1385652602-8528-7-git-send-email-ville.syrjala@linux.intel.com> <1386857089.6866.7.camel@intelbox> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id D929CFA943 for ; Thu, 12 Dec 2013 07:02:26 -0800 (PST) Received: by mail-ee0-f54.google.com with SMTP id e51so245238eek.41 for ; Thu, 12 Dec 2013 07:02:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1386857089.6866.7.camel@intelbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Dec 12, 2013 at 04:04:49PM +0200, Imre Deak wrote: > On Thu, 2013-11-28 at 17:30 +0200, ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj=E4l=E4 > > = > > Don't touch DPFC_RECOMP_CTL on FBC2, use RMW to update > > the FBC_CONTROL on FBC1 to make it easier for people to > > experiment with different numbers. Also fix the interval > > mask for FBC1. > = > As I understood the reason for removing DPFC_RECOMP support is that we > need to understand better how it affects performance etc. before > enabling it. That's something for the future. > = > We could still zero that register in case BIOS leaves there something > else but that can be done as a follow-up too. So: > Reviewed-by: Imre Deak This patch here doesn't really apply on dinq. Ville, can you pls resend? -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch