From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms Date: Thu, 12 Dec 2013 16:04:52 +0100 Message-ID: <20131212150452.GN9804@phenom.ffwll.local> References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com> <1385652602-8528-9-git-send-email-ville.syrjala@linux.intel.com> <1386857974.6866.10.camel@intelbox> <20131212143249.GB10036@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 874E2FA61C for ; Thu, 12 Dec 2013 07:04:01 -0800 (PST) Received: by mail-ee0-f46.google.com with SMTP id d49so296557eek.19 for ; Thu, 12 Dec 2013 07:04:00 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Dec 12, 2013 at 03:38:38PM +0100, Daniel Vetter wrote: > On Thu, Dec 12, 2013 at 3:32 PM, Ville Syrj=E4l=E4 > wrote: > > On Thu, Dec 12, 2013 at 04:19:34PM +0200, Imre Deak wrote: > >> On Thu, 2013-11-28 at 17:30 +0200, ville.syrjala@linux.intel.com wrote: > >> > From: Ville Syrj=E4l=E4 > >> > > >> > All mobile gen2 and gen3 chipsets should have FBC1, and the code > >> > should now handle them all. So just set has_fbc=3Dtrue for all such > >> > chipsets. > >> > > >> > Signed-off-by: Ville Syrj=E4l=E4 > >> > >> Based on the above we could also enable fbc for i830. In any case: > >> Reviewed-by: Imre Deak > > > > According to the spec there's no FBC on 830, so I guess my commit > > message was a tad incorrect. Some part of the spec hints that FBC > > might be avilable on 865 too, but in another part only 85x is > > mentioned. > = > Iirc fbc was mobile-only until ilk happened. So by that pattern I > wouldn't expect 865 to have it, since it's a desktop part. Ok I've merged 3 more patches from this series, but the last one kinda refused to apply on dinq. Can you please rebase? -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch