Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms

Imre Deak
2013-12-12T14:19:37Z

[-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --]

On Thu, 2013-11-28 at 17:30 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> All mobile gen2 and gen3 chipsets should have FBC1, and the code
> should now handle them all. So just set has_fbc=true for all such
> chipsets.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Based on the above we could also enable fbc for i830. In any case:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
> drivers/gpu/drm/i915/i915_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 0ec0fb3..923c8b6 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -172,6 +172,7 @@ static const struct intel_device_info intel_i85x_info = {
> .gen = 2, .is_i85x = 1, .is_mobile = 1, .num_pipes = 2,
> .cursor_needs_physical = 1,
> .has_overlay = 1, .overlay_needs_physical = 1,
> + .has_fbc = 1,
> .ring_mask = RENDER_RING,
> };
>
> @@ -191,6 +192,7 @@ static const struct intel_device_info intel_i915gm_info = {
> .cursor_needs_physical = 1,
> .has_overlay = 1, .overlay_needs_physical = 1,
> .supports_tv = 1,
> + .has_fbc = 1,
> .ring_mask = RENDER_RING,
> };
> static const struct intel_device_info intel_i945g_info = {
> @@ -203,6 +205,7 @@ static const struct intel_device_info intel_i945gm_info = {
> .has_hotplug = 1, .cursor_needs_physical = 1,
> .has_overlay = 1, .overlay_needs_physical = 1,
> .supports_tv = 1,
> + .has_fbc = 1,
> .ring_mask = RENDER_RING,
> };
>

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org