Re: [PATCH 6/8] drm/i915: Rework the FBC interval/stall stuff a bit

Chris Wilson
2013-11-29T13:54:01Z

On Thu, Nov 28, 2013 at 05:30:00PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Don't touch DPFC_RECOMP_CTL on FBC2, use RMW to update
> the FBC_CONTROL on FBC1 to make it easier for people to
> experiment with different numbers. Also fix the interval
> mask for FBC1.

I don't feel this is adequate to understand the changes in this patch.
In particular I see the non-i8xx paths being altered in a way that
doesn't seem to preserve the invariant register values.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre