Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms

Daniel Vetter
2013-12-12T15:04:01Z

On Thu, Dec 12, 2013 at 03:38:38PM +0100, Daniel Vetter wrote:
> On Thu, Dec 12, 2013 at 3:32 PM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Thu, Dec 12, 2013 at 04:19:34PM +0200, Imre Deak wrote:
> >> On Thu, 2013-11-28 at 17:30 +0200, ville.syrjala@linux.intel.com wrote:
> >> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> >
> >> > All mobile gen2 and gen3 chipsets should have FBC1, and the code
> >> > should now handle them all. So just set has_fbc=true for all such
> >> > chipsets.
> >> >
> >> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> Based on the above we could also enable fbc for i830. In any case:
> >> Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > According to the spec there's no FBC on 830, so I guess my commit
> > message was a tad incorrect. Some part of the spec hints that FBC
> > might be avilable on 865 too, but in another part only 85x is
> > mentioned.
>
> Iirc fbc was mobile-only until ilk happened. So by that pattern I
> wouldn't expect 865 to have it, since it's a desktop part.

Ok I've merged 3 more patches from this series, but the last one kinda
refused to apply on dinq. Can you please rebase?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch