From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: dont call irq_put when irq test
 is on
Date: Thu, 12 Dec 2013 17:46:47 +0100
Message-ID: <20131212164647.GP9804@phenom.ffwll.local>
References: <20131212125640.GZ10036@intel.com>
	<1386863682-5889-1-git-send-email-mika.kuoppala@intel.com>
	<20131212160616.GC10036@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54])
	by gabe.freedesktop.org (Postfix) with ESMTP id 80B48FB4A4
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 08:45:57 -0800 (PST)
Received: by mail-ee0-f54.google.com with SMTP id e51so304780eek.27
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 08:45:56 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131212160616.GC10036@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Dec 12, 2013 at 06:06:16PM +0200, Ville Syrj=E4l=E4 wrote:
> On Thu, Dec 12, 2013 at 05:54:42PM +0200, Mika Kuoppala wrote:
> > If test is running, irq_get was not called so we should gain
> > balance by not doing irq_put
> > =

> > "So the rule is: if you access unlocked values, you use ACCESS_ONCE().
> > You don't say "but it can't matter". Because you simply don't know."
> > -- Linus
> > =

> > v2: use local variable so it can't change during test (Chris)
> > =

> > v3: update commit msg and use ACCESS_ONCE (Ville)
> > =

> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> =

> Looks good.
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch