From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/8] drm/i915: Always use INTEL_INFO() to access the device_info structure Date: Thu, 12 Dec 2013 17:05:18 +0000 Message-ID: <20131212170518.GC14545@strange.amr.corp.intel.com> References: <1386859003-17246-1-git-send-email-damien.lespiau@intel.com> <1386859003-17246-3-git-send-email-damien.lespiau@intel.com> <20131212165821.GH6195@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E170FB644 for ; Thu, 12 Dec 2013 09:05:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131212165821.GH6195@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Dec 12, 2013 at 04:58:21PM +0000, Chris Wilson wrote: > On Thu, Dec 12, 2013 at 02:36:37PM +0000, Damien Lespiau wrote: > > If we make sure that all the dev_priv->info usages are wrapped by > > INTEL_INFO(), we can easily modify the ->info field to be structure and > > not a pointer while keeping the const protection in the INTEL_INFO() > > macro. > > Yuck. Would Jani's suggestion to transmogrify INTEL_INFO() into a function make you happier? Or is it the back and forth from *dev_priv to *dev to dev_priv->info that is of utmost disgust? -- Damien