From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 2/3] tests/gem_close_race: Adapt the test for Full PPGTT Date: Fri, 13 Dec 2013 17:51:12 +0100 Message-ID: <20131213165112.GV9804@phenom.ffwll.local> References: <1386951877-13778-1-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C247FBACF for ; Fri, 13 Dec 2013 08:50:21 -0800 (PST) Received: by mail-ea0-f182.google.com with SMTP id a15so999317eae.27 for ; Fri, 13 Dec 2013 08:50:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <1386951877-13778-1-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: oscar.mateo@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Dec 13, 2013 at 04:24:37PM +0000, oscar.mateo@intel.com wrote: > From: Oscar Mateo > > With Full PPGTT, each new fd creates a new context and thus a new > PPGTT, so we have to reduce the number of simultaneous fds or face > OOM problems. For every new PPGTT, its PDEs are stored in the GGTT > which imposes a limit of 1024 new contexts. We want to leave at > least 1/4 of the GGTT available for "important" stuff like scanout > buffers, so never open more than 768 fds. > > v2: Unconditionally use the lower limit, as suggested by Daniel > Vetter > > Signed-off-by: Oscar Mateo Merged, thanks for the patch. And --in-reply-to preferred for resending ;-) -Daniel > --- > tests/gem_close_race.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/gem_close_race.c b/tests/gem_close_race.c > index 6064c02..3a2d847 100644 > --- a/tests/gem_close_race.c > +++ b/tests/gem_close_race.c > @@ -136,7 +136,7 @@ static void run(int child) > gem_read(fd, handle, 0, &handle, sizeof(handle)); > } > > -#define NUM_FD 32000 > +#define NUM_FD 768 > > struct thread { > pthread_mutex_t mutex; > @@ -222,7 +222,7 @@ igt_main > } > > igt_subtest("process-exit") { > - igt_fork(child, 2000) > + igt_fork(child, NUM_FD) > run(child); > igt_waitchildren(); > } > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch