From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 05/17] drm/i915: Move ring_begin to signal() Date: Sat, 14 Dec 2013 10:42:12 -0800 Message-ID: <20131214184211.GA3633@bwidawsk.net> References: <1386994565-29395-1-git-send-email-benjamin.widawsky@intel.com> <1386994565-29395-6-git-send-email-benjamin.widawsky@intel.com> <20131214090503.GD1403@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 568EFFB356 for ; Sat, 14 Dec 2013 10:42:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131214090503.GD1403@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Dec 14, 2013 at 09:05:03AM +0000, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote: > > Add_request has always contained both the semaphore mailbox updates as > > well as the breadcrumb writes. Since the semaphore signal is the one > > which actually knows about the number of dwords it needs to emit to the > > ring, we move the ring_begin to that function. This allows us to remove > > the hideously shared #define > > We can now just split it up and use two intel_ring_begin(). And there is > no reason not to pack the semaphore commands tightly. > -Chris Tight packing comes in a later patch. I thought about multi ring begins, except I couldn't figure out a way to easily back out if a later one fails. It would be a shame to emit some/none of the semaphore updates, and then success on the breadcrumb/MI_USER_INTERRUPT (or vice versa). -- Ben Widawsky, Intel Open Source Technology Center