From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 09/17] drm/i915: init ring->id early Date: Sat, 14 Dec 2013 17:42:42 -0800 Message-ID: <20131215014242.GA614@bwidawsk.net> References: <1386994565-29395-1-git-send-email-benjamin.widawsky@intel.com> <1386994565-29395-10-git-send-email-benjamin.widawsky@intel.com> <20131214214534.GC5054@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E90CFAF6A for ; Sat, 14 Dec 2013 17:42:46 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131214214534.GC5054@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Dec 14, 2013 at 09:45:34PM +0000, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > Having the ring id all set up will allow us to use some macro shortcuts > > during ringbuffer init. Admittedly it leaves the code a bit confusing, > > having the initialization of the id member in a separate place - but I > > think the savings is worth it. > > This is not required since the macro could be written more simply as > ring[i]->id == i. > -Chris > It could be written as ring->id = i. Is that what you mean? I didn't quite follow the "not required" part. -- Ben Widawsky, Intel Open Source Technology Center