From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/14] drm/i915: Make ILK/SNB/IVB use HSW watermark code Date: Tue, 17 Dec 2013 11:13:28 +0100 Message-ID: <20131217101328.GP9804@phenom.ffwll.local> References: <1386251501-10602-1-git-send-email-ville.syrjala@linux.intel.com> <1387229918.2529.5.camel@ideak-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F5C2FC0AA for ; Tue, 17 Dec 2013 02:12:36 -0800 (PST) Received: by mail-ee0-f50.google.com with SMTP id c41so2729137eek.37 for ; Tue, 17 Dec 2013 02:12:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <1387229918.2529.5.camel@ideak-mobl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Dec 16, 2013 at 11:38:38PM +0200, Imre Deak wrote: > On Thu, 2013-12-05 at 15:51 +0200, ville.syrjala@linux.intel.com wrote: > > Back on the watermark horse. This series moves ILK/SNB/IVB over to the = HSW > > watermark code. > > = > > This series still has some underrun issues since the safe watermark > > update mechanism is yet to be introduced. However it shouldn't really > > be any worse than what we have ATM, and I'd like to have all the platfo= rms > > converted so that we have more systems that will excercise the new upda= te > > mechanism when it arrives. > = > Looks ok to me. I have a couple of bikesheds inlined, regardless of > those on the series: Yeah, that looks like good cleanups on top, but since Ville is already on vacation I've decided to pull the patches in already. -Daniel > Reviewed-by: Imre Deak > = > > = > > Ville Syrj=E4l=E4 (14): > > drm/i915: Add IVB DDB partitioning control > > drm/i915: Add ILK/SNB/IVB WM latency field support > > drm/i915: Avoid computing invalid WM levels when sprites/scaling = is enabled > > Revert "drm/i915/sprite: Always enable the scaler on IronLake" > > drm/i915: Fix LP1 sprite watermarks for ILK/SNB > > drm/i915: Fix LP1+ watermark disabling ILK > > drm/i915: Don't merge LP1+ watermarks on ILK/SNB/IVB when multipl= e pipes are enabled > > drm/i915: Disable FBC WM on ILK, and disable LP2+ when FBC is ena= bled > > drm/i915: Linetime watermarks are a HSW feature > > drm/i915: Disable LP1+ watermarks safely in init > > drm/i915: Move ILK/SNB/IVB over to the HSW WM code > > drm/i915: Try to fix the messy IVB sprite scaling workaround > > drm/i915: Don't disable primary when color keying is used > > drm/i915: Avoid underruns when disabling sprites > > = > > drivers/gpu/drm/i915/i915_drv.h | 1 - > > drivers/gpu/drm/i915/i915_reg.h | 2 + > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > drivers/gpu/drm/i915/intel_pm.c | 857 +++++++--------------------= -------- > > drivers/gpu/drm/i915/intel_sprite.c | 50 +- > > 5 files changed, 195 insertions(+), 717 deletions(-) > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch