From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference. Date: Mon, 6 Jan 2014 10:57:06 +0100 Message-ID: <20140106095706.GA16015@phenom.ffwll.local> References: <201312242050.CGH78112.JQFOSVMLOFtHOF@I-love.SAKURA.ne.jp> <20131225215249.GA3832@nuc-i3427.alporthouse.com> <201401032042.BJF09317.FJFQOFOVtSOLMH@I-love.SAKURA.ne.jp> <20140103125151.GA4367@nuc-i3427.alporthouse.com> <201401051008.FFH69706.JLOVMFFSQFHOOt@I-love.SAKURA.ne.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B8EDFC96D for ; Mon, 6 Jan 2014 01:55:55 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id t10so7850045eei.0 for ; Mon, 06 Jan 2014 01:55:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <201401051008.FFH69706.JLOVMFFSQFHOOt@I-love.SAKURA.ne.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Tetsuo Handa Cc: daniel.vetter@ffwll.ch, ben@bwidawsk.net, Intel Graphics Development , linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Jan 05, 2014 at 10:08:42AM +0900, Tetsuo Handa wrote: > Chris Wilson wrote: > > > Then, this file->pid in &dev->filelist keeps at least one reference. > > > OK. Updated patch follows. > > > > Looks good to me, and the comment is great. > > -Chris > > Please pick up this patch via your git tree. > > Also, please change from "" to whatever you like. For example, > dump_holder() in fs/gfs2/glock.c uses "(ended)" if comm is not available. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch