From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: fix fastboot pfit disable hack to update pipe w/h Date: Tue, 7 Jan 2014 10:52:04 -0800 Message-ID: <20140107105204.195652cb@jbarnes-desktop> References: <1387478881-2357-1-git-send-email-jbarnes@virtuousgeek.org> <20140106153123.18d8fdfe@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from alt-proxy17.mail.unifiedlayer.com (alt-proxy17.mail.unifiedlayer.com [66.147.241.60]) by gabe.freedesktop.org (Postfix) with SMTP id 0CA76FAF83 for ; Tue, 7 Jan 2014 10:49:34 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, 7 Jan 2014 08:07:13 +0100 Daniel Vetter wrote: > On Tue, Jan 7, 2014 at 12:31 AM, Jesse Barnes wrote: > > On Thu, 19 Dec 2013 10:48:01 -0800 > > Jesse Barnes wrote: > > > >> When fastbooting, we read out the pipe timings early on, and then in a > >> panel fitted config, disable the fitter later. But we weren't updating > >> the pipe src h/w, which meant the mouse cursor was clipped to the > >> pfitted size rather than the native size set later. Fix that up so the > >> cursor is visible in the new mode. > >> > >> Signed-off-by: Jesse Barnes > >> --- > >> drivers/gpu/drm/i915/intel_display.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > >> index 4d1357a..7e46d75 100644 > >> --- a/drivers/gpu/drm/i915/intel_display.c > >> +++ b/drivers/gpu/drm/i915/intel_display.c > >> @@ -2382,6 +2382,8 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y, > >> I915_WRITE(PF_WIN_POS(intel_crtc->pipe), 0); > >> I915_WRITE(PF_WIN_SZ(intel_crtc->pipe), 0); > >> } > >> + intel_crtc->config.pipe_src_w = adjusted_mode->crtc_hdisplay; > >> + intel_crtc->config.pipe_src_h = adjusted_mode->crtc_vdisplay; > >> } > >> > >> ret = dev_priv->display.update_plane(crtc, fb, x, y); > > > > References: https://bugzilla.kernel.org/show_bug.cgi?id=67591 > > The bug report doesn't say anything about the pipe config state > checker being unhappy. Are we missing a call to the checker for > fastboot somewhere to catch this stuff? Ah no, we do have a check there. I guess since we never updated it we were comparing two stale values? -- Jesse Barnes, Intel Open Source Technology Center