From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915/bdw: don't try to check IPS state
 on BDW
Date: Tue, 7 Jan 2014 13:33:44 -0800
Message-ID: <20140107133344.4565814d@jbarnes-desktop>
References: <1389054481-4111-1-git-send-email-jbarnes@virtuousgeek.org>
	<CA+gsUGSr02dJomUNjjAGpuM4i_UtRBuVF6sB2Lxfdw+BRuYKAg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from alt-proxy31.mail.unifiedlayer.com
	(alt-proxy31.mail.unifiedlayer.com [74.220.221.129])
	by gabe.freedesktop.org (Postfix) with SMTP id 82979FAC55
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  7 Jan 2014 13:31:17 -0800 (PST)
In-Reply-To: <CA+gsUGSr02dJomUNjjAGpuM4i_UtRBuVF6sB2Lxfdw+BRuYKAg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 7 Jan 2014 17:49:05 -0200
Paulo Zanoni <przanoni@gmail.com> wrote:

> 2014/1/6 Jesse Barnes <jbarnes@virtuousgeek.org>:
> > According to Art, we don't have a way to read back the state reliably at
> > runtime, at least not without risking disabling it again.  So drop the
> > readout and checking on BDW.
> 
> Based on that, we also need to:
> - Replace the TODO comment at hsw_enable_ips() with something else
> - Move the POSTING_READ() at hsw_disable_ips() to the IS_HASWELL() case
> - Print "enisabled" when someone reads i915_ips_status on BDW

All good changes.  Just sent an updated patch.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center