From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n
Date: Wed, 8 Jan 2014 17:14:43 +0100 [thread overview]
Message-ID: <20140108161443.GS4770@phenom.ffwll.local> (raw)
In-Reply-To: <20140108153843.GI8991@nuc-i3427.alporthouse.com>
On Wed, Jan 08, 2014 at 03:38:43PM +0000, Chris Wilson wrote:
> On Wed, Jan 08, 2014 at 04:19:06PM +0100, Daniel Vetter wrote:
> > A regression in the topic/ppgtt branch introduce in
> >
> > commit 87d60b63e0371529faaed0667d457e5022964010
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date: Fri Dec 6 14:11:29 2013 -0800
> >
> > drm/i915: Add PPGTT dumper
>
> I'm missing some context, what's the actual regression? Without debugfs
> the code will not be called and it just wastes a small amount of kernel
> memory, and seq_file should still be valid.
We don't include the respective headers for seq_printf, so compilation
fails. Very sloppy commit message from my side, I'll amend when merging.
Not sure whether the #ifdef'ery is really worth it though ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-08 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 15:19 [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n Daniel Vetter
2014-01-08 15:38 ` Chris Wilson
2014-01-08 16:14 ` Daniel Vetter [this message]
2014-01-08 16:41 ` Chris Wilson
2014-01-08 20:27 ` Daniel Vetter
2014-01-09 23:40 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108161443.GS4770@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox