From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n Date: Wed, 8 Jan 2014 17:14:43 +0100 Message-ID: <20140108161443.GS4770@phenom.ffwll.local> References: <1389194346-30855-1-git-send-email-daniel.vetter@ffwll.ch> <20140108153843.GI8991@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 46396F9E5F for ; Wed, 8 Jan 2014 08:13:28 -0800 (PST) Received: by mail-ee0-f47.google.com with SMTP id e51so638515eek.6 for ; Wed, 08 Jan 2014 08:13:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140108153843.GI8991@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 08, 2014 at 03:38:43PM +0000, Chris Wilson wrote: > On Wed, Jan 08, 2014 at 04:19:06PM +0100, Daniel Vetter wrote: > > A regression in the topic/ppgtt branch introduce in > > > > commit 87d60b63e0371529faaed0667d457e5022964010 > > Author: Ben Widawsky > > Date: Fri Dec 6 14:11:29 2013 -0800 > > > > drm/i915: Add PPGTT dumper > > I'm missing some context, what's the actual regression? Without debugfs > the code will not be called and it just wastes a small amount of kernel > memory, and seq_file should still be valid. We don't include the respective headers for seq_printf, so compilation fails. Very sloppy commit message from my side, I'll amend when merging. Not sure whether the #ifdef'ery is really worth it though ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch