From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] build: Added -UNDEBUG to tools/Android.mk Date: Wed, 8 Jan 2014 16:27:09 +0000 Message-ID: <20140108162709.GC19801@strange.amr.corp.intel.com> References: <1389197226-6928-1-git-send-email-devon.davies@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 7192DFAA9B for ; Wed, 8 Jan 2014 08:27:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389197226-6928-1-git-send-email-devon.davies@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: oscar.mateo@intel.com Cc: devon.davies@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 08, 2014 at 04:07:06PM +0000, devon.davies@intel.com wrote: > From: Devon Davies > > NDEBUG is defined by default in Android and causes assert(x) to be > defined as void(x). This change ensures that asserts work as > expected in tools. > > This flag is already inside tests/Android.mk > > Signed-off-by: Devon Davies Hi Oscar, The change looks good from here, mind dropping a Reviewed-By tag as you were the one looking at that in the first place? Thanks, -- Damien > --- > tools/Android.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/Android.mk b/tools/Android.mk > index 4a19b6c..5bda489 100644 > --- a/tools/Android.mk > +++ b/tools/Android.mk > @@ -40,7 +40,7 @@ define add_tool > > LOCAL_CFLAGS += -DHAVE_TERMIOS_H > LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM > - LOCAL_CFLAGS += -DANDROID > + LOCAL_CFLAGS += -DANDROID -UNDEBUG > LOCAL_CFLAGS += -std=c99 > # FIXME: drop once Bionic correctly annotates "noreturn" on pthread_exit > LOCAL_CFLAGS += -Wno-error=return-type > -- > 1.7.9.5 > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx