From: Damien Lespiau <damien.lespiau@intel.com>
To: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Cc: "Davies, Devon" <devon.davies@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] build: Added -UNDEBUG to tools/Android.mk
Date: Wed, 8 Jan 2014 17:20:28 +0000 [thread overview]
Message-ID: <20140108172028.GA11830@strange.amr.corp.intel.com> (raw)
In-Reply-To: <92648605EABDA246B775AAB04C95A7A30123B5F4@IRSMSX103.ger.corp.intel.com>
On Wed, Jan 08, 2014 at 05:13:28PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: intel-gfx-bounces@lists.freedesktop.org [mailto:intel-gfx-
> > bounces@lists.freedesktop.org] On Behalf Of devon.davies@intel.com
> > Sent: Wednesday, January 08, 2014 4:07 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Davies, Devon
> > Subject: [Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk
> >
> > From: Devon Davies <devon.davies@intel.com>
> >
> > NDEBUG is defined by default in Android and causes assert(x) to be defined as
> > void(x). This change ensures that asserts work as expected in tools.
> >
> > This flag is already inside tests/Android.mk
>
> I discussed and agreed to Devon´s solution with him before, so:
> Reviewed-by: Oscar Mateo <oscar.mateo@intel.com>
Thanks for the patch and review, pushed.
--
Damien
prev parent reply other threads:[~2014-01-08 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 16:07 [PATCH] build: Added -UNDEBUG to tools/Android.mk devon.davies
2014-01-08 16:27 ` Damien Lespiau
2014-01-08 17:13 ` Mateo Lozano, Oscar
2014-01-08 17:20 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108172028.GA11830@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=devon.davies@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox