From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] build: Added -UNDEBUG to tools/Android.mk
Date: Wed, 8 Jan 2014 17:20:28 +0000
Message-ID: <20140108172028.GA11830@strange.amr.corp.intel.com>
References: <1389197226-6928-1-git-send-email-devon.davies@intel.com>
	<92648605EABDA246B775AAB04C95A7A30123B5F4@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 622FEFB28B
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  8 Jan 2014 09:20:34 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <92648605EABDA246B775AAB04C95A7A30123B5F4@IRSMSX103.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Cc: "Davies, Devon" <devon.davies@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 08, 2014 at 05:13:28PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: intel-gfx-bounces@lists.freedesktop.org [mailto:intel-gfx-
> > bounces@lists.freedesktop.org] On Behalf Of devon.davies@intel.com
> > Sent: Wednesday, January 08, 2014 4:07 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Davies, Devon
> > Subject: [Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk
> > =

> > From: Devon Davies <devon.davies@intel.com>
> > =

> > NDEBUG is defined by default in Android and causes assert(x) to be defi=
ned as
> > void(x). This change ensures that asserts work as expected in tools.
> > =

> > This flag is already inside tests/Android.mk
> =

> I discussed and agreed to Devon=B4s solution with him before, so:
> Reviewed-by: Oscar Mateo <oscar.mateo@intel.com>

Thanks for the patch and review, pushed.

-- =

Damien