From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: Excessive WARN()s in Intel 915 driver Date: Wed, 8 Jan 2014 20:43:23 +0200 Message-ID: <20140108184323.GL4800@intel.com> References: <20140108161713.GT4770@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5118FFB25B for ; Wed, 8 Jan 2014 10:43:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140108161713.GT4770@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Alan Stern , intel-gfx , Kernel development list List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 08, 2014 at 05:17:13PM +0100, Daniel Vetter wrote: > On Wed, Jan 08, 2014 at 11:08:08AM -0500, Alan Stern wrote: > > On Tue, 7 Jan 2014, Daniel Vetter wrote: > > = > > > I really want users to report these issues, and excessive WARNs seems > > > to be the only way to get those reports. Please boot with > > > drm.debug=3D0xe added to your kernel cmdline and reproduce this issue= s. > > > Also, which precise kernel are you running? Testing latest -rc is > > > always recommended, this state checker code is fairly new and gets > > > constantly extended and bugs fixed ... > > = > > Here you go. This is the dmesg output after booting with > > drm.debug=3D0xe. Pay no attention to the "AS" suffix in the version > > string; this is pristine 3.13-rc7. > = > That's strange, I've thought we've fixed the last struggling mismatch in > the lvds borber bits stuff. Can you please try latest drm-intel-nightly > from > = > http://cgit.freedesktop.org/~danvet/drm-intel/ > = > Thanks, Daniel The log looks fairly clear to me: 1. initially panel fitter is enabled on pipe B, and pipe B is outputting to LVDS and VGA. Border is enabled. 2. pipe A gets enabled outputting to LVDS. This will overwrite the LVDS border bits 3. pipe B is still active so we do the state check, but as the LVDS border bits have been clobbered earlier, the state checker gets angry This actually hits another problem we still have. We've changing the pipe for the LVDS port w/o shutting the port down in between. That doesn't sound entirely safe. I wonder if we still have some real issues preventing this change? * intel_modeset_setup_hw_state does not. */ *modeset_pipes &=3D 1 << intel_crtc->pipe; - *prepare_pipes &=3D 1 << intel_crtc->pipe; = DRM_DEBUG_KMS("set mode pipe masks: modeset: %x, prepare: %x, disab= le: %x\n", *modeset_pipes, *prepare_pipes, *disable_pipes); -- = Ville Syrj=E4l=E4 Intel OTC