From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n
Date: Thu, 9 Jan 2014 15:40:17 -0800 [thread overview]
Message-ID: <20140109234017.GD4522@bwidawsk.net> (raw)
In-Reply-To: <1389212849-6738-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Jan 08, 2014 at 09:27:29PM +0100, Daniel Vetter wrote:
> A regression in the topic/ppgtt branch introduce in
>
> commit 87d60b63e0371529faaed0667d457e5022964010
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date: Fri Dec 6 14:11:29 2013 -0800
>
> drm/i915: Add PPGTT dumper
>
> The issue is that we're missing the definitions for the seq_file
> functions and hence compilation fails.
>
> v2: Just include the right header instead of splattering #ifdefs all
> over the place (Chris).
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Reported-by: Antti Koskipaa <antti.koskipaa@linux.intel.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 998f9a0b322a..6e9e6219f093 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -22,6 +22,7 @@
> *
> */
>
> +#include <linux/seq_file.h>
> #include <drm/drmP.h>
> #include <drm/i915_drm.h>
> #include "i915_drv.h"
> --
> 1.8.4.3
>
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2014-01-09 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 15:19 [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n Daniel Vetter
2014-01-08 15:38 ` Chris Wilson
2014-01-08 16:14 ` Daniel Vetter
2014-01-08 16:41 ` Chris Wilson
2014-01-08 20:27 ` Daniel Vetter
2014-01-09 23:40 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109234017.GD4522@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox