From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: fix ppgtt dump code for DEBUG_FS=n
Date: Thu, 9 Jan 2014 15:40:17 -0800
Message-ID: <20140109234017.GD4522@bwidawsk.net>
References: <20140108164115.GA27406@nuc-i3427.alporthouse.com>
	<1389212849-6738-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id 86727FC1AE
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  9 Jan 2014 15:40:27 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1389212849-6738-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 08, 2014 at 09:27:29PM +0100, Daniel Vetter wrote:
> A regression in the topic/ppgtt branch introduce in
> 
> commit 87d60b63e0371529faaed0667d457e5022964010
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Fri Dec 6 14:11:29 2013 -0800
> 
>     drm/i915: Add PPGTT dumper
> 
> The issue is that we're missing the definitions for the seq_file
> functions and hence compilation fails.
> 
> v2: Just include the right header instead of splattering #ifdefs all
> over the place (Chris).
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Reported-by: Antti Koskipaa <antti.koskipaa@linux.intel.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 998f9a0b322a..6e9e6219f093 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -22,6 +22,7 @@
>   *
>   */
>  
> +#include <linux/seq_file.h>
>  #include <drm/drmP.h>
>  #include <drm/i915_drm.h>
>  #include "i915_drv.h"
> -- 
> 1.8.4.3
> 

-- 
Ben Widawsky, Intel Open Source Technology Center