Re: [PATCH 3/3] drm/i915: Set the digital port encoder personality during modeset

[Damien Lespiau <damien.lespiau@intel.com>]

On Tue, Jan 07, 2014 at 02:55:55PM -0200, Paulo Zanoni wrote:
> +static bool
> +intel_ddi_ensure_encoder_type(struct intel_encoder *encoder)

[...]

> +		if (connector->base.status == connector_status_connected) {
> +			DRM_DEBUG_KMS("Can't change DDI %c personality to %s, it has a connected %s device\n",
> +				      port_name(port),
> +				      intel_output_name(new_encoder_type),
> +				      intel_output_name(old_encoder_type));
> +			return false;
> +		}

Actually, this test should be:

                if (old_encoder_type != INTEL_OUTPUT_UNKNOWN &&
                    connector->base.status == connector_status_connected) {

Otherwise we miss the case I wanted the patch for in the first place: Forcing a
not-yet-sexed DDI connector (type == UNKNOWN) on the command line, say.
video=HDMI-A-1:1024x768e. In that case, we end up with type == UNKNOWN and
connector->base.status == connector_status_connected, but still want to force
the DDI personality to HDMI.

--
Damien