From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Only WARN about a stuck hotplug irq ONCE Date: Fri, 10 Jan 2014 20:57:03 +0100 Message-ID: <20140110195703.GK4770@phenom.ffwll.local> References: <1389379761-16837-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) by gabe.freedesktop.org (Postfix) with ESMTP id A6E78FC41F for ; Fri, 10 Jan 2014 11:55:46 -0800 (PST) Received: by mail-ea0-f173.google.com with SMTP id o10so2262879eaj.4 for ; Fri, 10 Jan 2014 11:55:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389379761-16837-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 10, 2014 at 06:49:20PM +0000, Chris Wilson wrote: > It seems that hardware that is broken enough to emit a hotplug IRQ even > though the pin is surposedly disable, will do so indefinitely. > > References: https://bugzilla.redhat.com/show_bug.cgi?id=1051170 > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1051369 > Signed-off-by: Chris Wilson gm45, unsurprisingly ... Underlying cause should be fixed with commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83 Author: Daniel Vetter Date: Fri Jul 26 11:27:49 2013 +0200 drm/i915: fix gen4 digital port hotplug definitions Or at least that's my hope. For further debug help, care to also dump the hotplug_trigger bits in the format string while at it? -Daniel > --- > drivers/gpu/drm/i915/i915_irq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index ec67bb8aff0a..3be8bcd4d797 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1247,9 +1247,9 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev, > spin_lock(&dev_priv->irq_lock); > for (i = 1; i < HPD_NUM_PINS; i++) { > > - WARN(((hpd[i] & hotplug_trigger) && > - dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED), > - "Received HPD interrupt although disabled\n"); > + WARN_ONCE(hpd[i] & hotplug_trigger && > + dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED, > + "Received HPD interrupt although disabled\n"); > > if (!(hpd[i] & hotplug_trigger) || > dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED) > -- > 1.8.5.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch