From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm: provide a helper for the encoder possible_crtcs mask
Date: Mon, 13 Jan 2014 12:47:06 +0000 [thread overview]
Message-ID: <20140113124706.GW15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CANq1E4RL+P=E8xSpTDiBuPWh=cuHBaxqVck6PGNcNYULCCwbUQ@mail.gmail.com>
On Mon, Jan 13, 2014 at 12:58:54PM +0100, David Herrmann wrote:
> Does that -1 ever make sense? We don't support mode-object-hotplugging
> so all "drm_crtc" objects are known at initialization time. I'd rather
> put a BUG() here than a silent -1. This also makes drm_crtc_mask()
> redundant.
I disagree with that last statement. drm_crtc_mask() is still useful
for converting to the mask, rather than having that open coded all
over the place. It probably makes more sense for drm_crtc_mask() to
become a helper in a header file though.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-01-13 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 11:46 [PATCH 0/2] drm: Introduce drm_crtc_index() and drm_crtc_mask() Thierry Reding
2014-01-13 11:46 ` [PATCH 1/2] drm: provide a helper for the encoder possible_crtcs mask Thierry Reding
2014-01-13 11:58 ` David Herrmann
2014-01-13 12:47 ` Russell King - ARM Linux [this message]
2014-01-13 13:50 ` David Herrmann
2014-01-13 13:55 ` Russell King - ARM Linux
2014-01-13 13:57 ` David Herrmann
2014-01-13 13:14 ` Jani Nikula
2014-01-13 11:46 ` [PATCH 2/2] drm/i915: Use drm_crtc_mask() helper Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113124706.GW15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox