From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] i915: send D1 opregion notification Date: Tue, 14 Jan 2014 10:26:02 +0100 Message-ID: <20140114092602.GR4770@phenom.ffwll.local> References: <1389648765-10904-1-git-send-email-kristen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EB8EFA244 for ; Tue, 14 Jan 2014 01:26:08 -0800 (PST) Received: by mail-ea0-f177.google.com with SMTP id n15so3814470ead.36 for ; Tue, 14 Jan 2014 01:26:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389648765-10904-1-git-send-email-kristen@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Kristen Carlson Accardi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote: > The opregion notification for runtime suspend should be D1, not D3. > This is to maintain compatibility with firmware. > > Signed-off-by: Kristen Carlson Accardi > --- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 61fb9fc..a6c370a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device) > > del_timer_sync(&dev_priv->gpu_error.hangcheck_timer); > dev_priv->pm.suspended = true; > - intel_opregion_notify_adapter(dev, PCI_D3cold); > + intel_opregion_notify_adapter(dev, PCI_D1); This needs a bigger comment and some mention on which platforms we exactly need this ... Or do the bios people plan to stick to this for bdw/vlv and all the further stuff? -Daniel > > return 0; > } > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch