From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] i915: send D1 opregion notification
Date: Tue, 14 Jan 2014 11:19:44 -0800
Message-ID: <20140114111944.61abeefb@jbarnes-desktop>
References: <1389648765-10904-1-git-send-email-kristen@linux.intel.com>
	<20140114092602.GR4770@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from alt-proxy6.mail.unifiedlayer.com
	(alt-proxy6.mail.unifiedlayer.com [66.147.245.65])
	by gabe.freedesktop.org (Postfix) with SMTP id 2F760106492
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 14 Jan 2014 11:19:43 -0800 (PST)
In-Reply-To: <20140114092602.GR4770@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Kristen Carlson Accardi <kristen@linux.intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 14 Jan 2014 10:26:02 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> > The opregion notification for runtime suspend should be D1, not D3.
> > This is to maintain compatibility with firmware.
> > 
> > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 61fb9fc..a6c370a 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
> >  
> >  	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> >  	dev_priv->pm.suspended = true;
> > -	intel_opregion_notify_adapter(dev, PCI_D3cold);
> > +	intel_opregion_notify_adapter(dev, PCI_D1);
> 
> This needs a bigger comment and some mention on which platforms we exactly
> need this ... Or do the bios people plan to stick to this for bdw/vlv and
> all the further stuff?

Doc # would help too, even if it's CDI or internal only... I don't know
where to find this info, or if I did I've forgotten.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center