From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] i915: send D1 opregion notification Date: Wed, 15 Jan 2014 10:00:04 +0100 Message-ID: <20140115090004.GX4770@phenom.ffwll.local> References: <1389742575-3917-1-git-send-email-kristen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com [209.85.215.171]) by gabe.freedesktop.org (Postfix) with ESMTP id CCB37107144 for ; Wed, 15 Jan 2014 01:00:09 -0800 (PST) Received: by mail-ea0-f171.google.com with SMTP id h10so302765eak.2 for ; Wed, 15 Jan 2014 01:00:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389742575-3917-1-git-send-email-kristen@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Kristen Carlson Accardi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 14, 2014 at 03:36:15PM -0800, Kristen Carlson Accardi wrote: > The opregion notification for runtime suspend is currently D1, not D3. > > Signed-off-by: Kristen Carlson Accardi Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_drv.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 61fb9fc..5a26d76 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -925,7 +925,15 @@ static int i915_runtime_suspend(struct device *device) > > del_timer_sync(&dev_priv->gpu_error.hangcheck_timer); > dev_priv->pm.suspended = true; > - intel_opregion_notify_adapter(dev, PCI_D3cold); > + > + /* > + * current versions of firmware which depend on this opregion > + * notification have repurposed the D1 definition to mean > + * "runtime suspended" vs. what you would normally expect (D3) > + * to distinguish it from notifications that might be sent > + * via the suspend path. > + */ > + intel_opregion_notify_adapter(dev, PCI_D1); > > return 0; > } > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch