From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: Move pipecrc debug functions
 to new file
Date: Wed, 15 Jan 2014 12:04:37 -0800
Message-ID: <20140115200437.GA1210@bwidawsk.net>
References: <1389708847-25038-1-git-send-email-benjamin.widawsky@intel.com>
	<1389708847-25038-2-git-send-email-benjamin.widawsky@intel.com>
	<20140115012200.GA26338@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3BB86107999
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 15 Jan 2014 12:04:41 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140115012200.GA26338@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 15, 2014 at 01:22:00AM +0000, Damien Lespiau wrote:
> On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote:
> > +#include <linux/debugfs.h>
> > +#include <linux/fs.h>
> > +#include <linux/seq_file.h>
> > +#include <linux/circ_buf.h>
> > +#include <linux/ctype.h>
> > +#if 0
> > +#include <drm/drm_crtc.h>
> > +#include <drm/drmP.h>
> > +#endif
> 
> Could remove that #if
> 
Thanks, I left that in by accident.

> Last time I remember we talked about a intel_display_test.c where we
> could shove more stuff (Rodrigo's DP CRC maybe). Either that or Daniel
> last suggestion seems fine (definitely intel_ though, has to do with the
> display)
> 
> -- 
> Damien


-- 
Ben Widawsky, Intel Open Source Technology Center