public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jeff McGee <jeff.mcgee@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: IGT conventions
Date: Wed, 15 Jan 2014 17:26:28 -0600	[thread overview]
Message-ID: <20140115232628.GC14542@jeffdesk> (raw)

I have a few questions about conventions observed in writing IGT tests.

I don't see any standard wrapper for logging other than the logging that goes
with certain igt_ control flow functions. Is it recommended to limit logging to
just these? I see some different approaches to supporting verbose modes. Is
it just up to each test?

Any recommendations on subtest granularity? Testing boils down to repeated
cycles of 'do something' then 'assert something'. Just wondering if there is a
guideline on how many of those cycles should each subtest contain. Probably
this is very case specific.

Also wondering if something like an igt_warn function to go with igt_require
and igt_assert has been considered. There might be a case where some condition
is not met which causes the test to become limited in its effectiveness but
still valid. We might still want to run the test and let it pass but attach a
caveat. Or would adding this gray area just be too complicating.

Thanks
Jeff

             reply	other threads:[~2014-01-15 23:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 23:26 Jeff McGee [this message]
2014-01-15 23:55 ` IGT conventions Daniel Vetter
2014-01-16  9:27   ` Daniel Vetter
2014-01-16 16:43     ` Jeff McGee
2014-01-22 20:40       ` Jeff McGee
2014-01-22 20:53         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115232628.GC14542@jeffdesk \
    --to=jeff.mcgee@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox