From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff McGee Subject: Re: IGT conventions Date: Thu, 16 Jan 2014 10:43:36 -0600 Message-ID: <20140116164336.GD14542@jeffdesk> References: <20140115232628.GC14542@jeffdesk> <20140115235516.GB4770@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FDB51060BB for ; Thu, 16 Jan 2014 08:37:23 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 16, 2014 at 10:27:03AM +0100, Daniel Vetter wrote: > On Thu, Jan 16, 2014 at 12:55 AM, Daniel Vetter wrote: > > Anything you put out to stderr will be tracked as a "warn" in piglit. Atm > > we don't have any such use-case though I think, mostly since keeping > > unbuffer stderr and buffered stdout in sync is a pain ;-) But I guess we > > could formalize this a bit if you see it useful for you with a > > > > #define igt_warn(a...) fprintf(stderr, a) > > > > or something like that. Some of the checks in kms_flip.c might benefit > > from this, since on a lot of our platforms the rather stringent timing > > checks often fail randomly. But besides such corner-cases I kinda prefer > > if we just split up testcases more instead of trying to be really clever > > with the level of fail encounter and reported. > > Actually if we put an fflush(stdout); before the fprintf then we would > not have any issues with buffered vs. unbuffered. And for consistency > maybe we could define igt_warn as just fputs and igt_warn_f as the > full printf thing. > > If you think this is useful for your tests then I'll happily merge a > patch to add igt_warn* Thanks for all the feedback. I'll see if something like this is really necessary for my cases. Agree that the simplicity of pass, skip, or fail may be best. Jeff