From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Eliminate lots of WARNs when there's no backlight present
Date: Thu, 16 Jan 2014 19:09:13 +0200 [thread overview]
Message-ID: <20140116170913.GO9454@intel.com> (raw)
In-Reply-To: <CAKMK7uF2GEuT9Rqo_QSGk3oeuHZBTx9Xgx=FbtQmbBb+QvV+hg@mail.gmail.com>
On Thu, Jan 16, 2014 at 05:55:48PM +0100, Daniel Vetter wrote:
> On Thu, Jan 16, 2014 at 5:27 PM, <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > My 855gm doesn't register the intel backlight but it still ends up
> > calling the backlight code to enable/disable the backlight via the
> > LVDS code. This leads to some WARNs due to backlight.max being 0.
> >
> > Let's have intel_panel_enable_backlight() and intel_panel_disable_backlight()
> > check whether there's a backlight present or not.
> >
> > Also move the backlight.present check from asle_set_backlight() into
> > intel_panel_set_backlight() for some extra symmetry.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Wouldn't that be a perfect machine to test Jani's
> init-backlight-from-vbt patch? Iirc all the infrastructure is now
> there ...
My assumption has ben that the intel backlight stuff isn't hooked up
to anything. But I guess I could give it a go.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-01-16 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:27 [PATCH] drm/i915: Eliminate lots of WARNs when there's no backlight present ville.syrjala
2014-01-16 16:55 ` Daniel Vetter
2014-01-16 17:09 ` Ville Syrjälä [this message]
2014-01-17 11:30 ` Jani Nikula
2014-01-17 13:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116170913.GO9454@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox