From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: clean up HPD IRQ debug printing Date: Thu, 16 Jan 2014 22:31:56 +0100 Message-ID: <20140116213156.GE4770@phenom.ffwll.local> References: <1389895014-6727-1-git-send-email-imre.deak@intel.com> <1389895014-6727-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B8751063AE for ; Thu, 16 Jan 2014 13:32:01 -0800 (PST) Received: by mail-ea0-f178.google.com with SMTP id a15so260769eae.9 for ; Thu, 16 Jan 2014 13:32:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389895014-6727-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 16, 2014 at 07:56:54PM +0200, Imre Deak wrote: > Atm, we don't print these events for all platforms and for VLV/G4X we > also print them for DP AUX completion events which is unnecessary spam. > Fix both issues. > > Signed-off-by: Imre Deak Both merged, thanks. Aside: Paulo asked me to go back to explicit ack mails again. Since I don't really care either way I'll do that. Worst case I need to start scripting it a bit ;-) Cheers, Daniel > --- > drivers/gpu/drm/i915/i915_irq.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 6d11e25..6e1c2ff 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1230,6 +1230,9 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev, > if (!hotplug_trigger) > return; > > + DRM_DEBUG_DRIVER("hotplug event received, stat 0x%08x\n", > + hotplug_trigger); > + > spin_lock(&dev_priv->irq_lock); > for (i = 1; i < HPD_NUM_PINS; i++) { > > @@ -1468,9 +1471,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg) > u32 hotplug_status = I915_READ(PORT_HOTPLUG_STAT); > u32 hotplug_trigger = hotplug_status & HOTPLUG_INT_STATUS_I915; > > - DRM_DEBUG_DRIVER("hotplug event received, stat 0x%08x\n", > - hotplug_status); > - > intel_hpd_irq_handler(dev, hotplug_trigger, hpd_status_i915); > > if (hotplug_status & DP_AUX_CHANNEL_MASK_INT_STATUS_G4X) > @@ -3407,9 +3407,6 @@ static irqreturn_t i915_irq_handler(int irq, void *arg) > u32 hotplug_status = I915_READ(PORT_HOTPLUG_STAT); > u32 hotplug_trigger = hotplug_status & HOTPLUG_INT_STATUS_I915; > > - DRM_DEBUG_DRIVER("hotplug event received, stat 0x%08x\n", > - hotplug_status); > - > intel_hpd_irq_handler(dev, hotplug_trigger, hpd_status_i915); > > I915_WRITE(PORT_HOTPLUG_STAT, hotplug_status); > @@ -3657,9 +3654,6 @@ static irqreturn_t i965_irq_handler(int irq, void *arg) > HOTPLUG_INT_STATUS_G4X : > HOTPLUG_INT_STATUS_I915); > > - DRM_DEBUG_DRIVER("hotplug event received, stat 0x%08x\n", > - hotplug_status); > - > intel_hpd_irq_handler(dev, hotplug_trigger, > IS_G4X(dev) ? hpd_status_g4x : hpd_status_i915); > > -- > 1.8.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch