From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Re-enable underrun reporting after 2 secs
Date: Fri, 17 Jan 2014 19:12:17 +0200 [thread overview]
Message-ID: <20140117171217.GR9454@intel.com> (raw)
In-Reply-To: <20140117170013.GK4770@phenom.ffwll.local>
On Fri, Jan 17, 2014 at 06:00:13PM +0100, Daniel Vetter wrote:
> On Fri, Jan 17, 2014 at 11:44:33AM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > I'm interested in underruns so having the totally off is not good. After
> > disabling underruns, re-enable them after 2 seconds. I just added one
> > timer for this, even though we should have one for each PCH and CPU,
> > or maybe even per pipe/transcoder, but then we should track underrun
> > disable also per pipe/transcoder.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The kernel has some neat ratelimiting stuff in ratelimit.h. You've looked
> into that? Open coding timer code always freaks me out a bit because of
> the bazillion ways you can screw up jiffy handling ;-)
Nope didn't really look. printk_timed_ratelimit() would seem like a
reasonable thing, except on PCH platforms we're also limiting the
interrupts themself, not just the printks. So using prink ratelimiting
can't give us quite the same thing.
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2014-01-17 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 9:44 [PATCH 0/3] drm/i915: FIFO underrun reporting changes ville.syrjala
2014-01-17 9:44 ` [PATCH 1/3] drm/i915: Limit FIFO underrun reports on GMCH platforms ville.syrjala
2014-01-24 18:37 ` Paulo Zanoni
2014-01-17 9:44 ` [PATCH 2/3] drm/i915: Make underruns DRM_ERROR ville.syrjala
2014-01-24 18:42 ` Paulo Zanoni
2014-01-25 19:14 ` Daniel Vetter
2014-01-17 9:44 ` [PATCH 3/3] drm/i915: Re-enable underrun reporting after 2 secs ville.syrjala
2014-01-17 17:00 ` Daniel Vetter
2014-01-17 17:12 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117171217.GR9454@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox