From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Re-enable underrun reporting
 after 2 secs
Date: Fri, 17 Jan 2014 19:12:17 +0200
Message-ID: <20140117171217.GR9454@intel.com>
References: <1389951873-7742-1-git-send-email-ville.syrjala@linux.intel.com>
	<1389951873-7742-4-git-send-email-ville.syrjala@linux.intel.com>
	<20140117170013.GK4770@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6D081105B7D
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 17 Jan 2014 09:16:02 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140117170013.GK4770@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 17, 2014 at 06:00:13PM +0100, Daniel Vetter wrote:
> On Fri, Jan 17, 2014 at 11:44:33AM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > I'm interested in underruns so having the totally off is not good. After
> > disabling underruns, re-enable them after 2 seconds. I just added one
> > timer for this, even though we should have one for each PCH and CPU,
> > or maybe even per pipe/transcoder, but then we should track underrun
> > disable also per pipe/transcoder.
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> The kernel has some neat ratelimiting stuff in ratelimit.h. You've looked
> into that? Open coding timer code always freaks me out a bit because of
> the bazillion ways you can screw up jiffy handling ;-)

Nope didn't really look. printk_timed_ratelimit() would seem like a
reasonable thing, except on PCH platforms we're also limiting the
interrupts themself, not just the printks. So using prink ratelimiting
can't give us quite the same thing.

-- =

Ville Syrj=E4l=E4
Intel OTC