From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't disable DP port after a failed link training
Date: Fri, 17 Jan 2014 18:13:33 +0100 [thread overview]
Message-ID: <20140117171333.GL4770@phenom.ffwll.local> (raw)
In-Reply-To: <20140117135843.GC4196@nuc-i3427.alporthouse.com>
On Fri, Jan 17, 2014 at 01:58:43PM +0000, Chris Wilson wrote:
> On Fri, Jan 17, 2014 at 03:46:43PM +0200, Imre Deak wrote:
> > Atm after a failed link training we disable the DP port. This can happen
> > during a modeset-enable or a DP link re-establishment. The latter can be
> > a problem and we shouldn't disable the DP port, see the previous patch for
> > the reasoning. In the former case the right thing would be to disable
> > the DP port, but also the rest of the pipe.
> >
> > As a stop-gap solution leave the DP port enabled in both cases. It is an
> > improvement on its own (avoiding HW lock ups) and the proper solution
> > for the first case requires a bigger change, so let's keep that on the
> > TODO list.
> >
> > v2:
> > - fix explanation of change impact (Chris)
> >
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> and r-b for patch 1 as well (if I didn't send it).
Both merged, thanks.
-Daniel
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-01-17 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:35 [PATCH 1/2] drm/i915: don't disable the DP port if the link is lost Imre Deak
2014-01-16 16:35 ` [PATCH 2/2] drm/i915: don't disable DP port after a failed link training Imre Deak
2014-01-16 16:58 ` Chris Wilson
2014-01-16 17:01 ` Daniel Vetter
2014-01-16 20:39 ` Chris Wilson
2014-01-16 21:27 ` Daniel Vetter
2014-01-16 17:05 ` Imre Deak
2014-01-17 13:46 ` [PATCH] " Imre Deak
2014-01-17 13:58 ` Chris Wilson
2014-01-17 17:13 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117171333.GL4770@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox