From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Shuffle modeset reset handling
	around
Date: Mon, 20 Jan 2014 17:12:48 +0100
Message-ID: <20140120161248.GG15089@phenom.ffwll.local>
References: <CA+gsUGTB7_n6fYmq5_ZgEtDnVdakv0F+MaLp8ui9ht3UgXXdVg@mail.gmail.com>
	<1389907724-22652-1-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGQuGSqiREgu4RNFyG2Ry01QBhC7qyS99zSGEYrgL3OVRA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com
	[209.85.215.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0545BFAEDD
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 20 Jan 2014 08:12:52 -0800 (PST)
Received: by mail-ea0-f181.google.com with SMTP id m10so3209315eaj.26
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 20 Jan 2014 08:12:51 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGQuGSqiREgu4RNFyG2Ry01QBhC7qyS99zSGEYrgL3OVRA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 17, 2014 at 06:14:50PM -0200, Paulo Zanoni wrote:
> 2014/1/16 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Currently we're doing the reset handling a bit late, and we're doing
> > it both in the driver load code and on resume. This makes it unusable
> > for e.g. resetting the panel power sequence state like Paulo wants to.
> >
> > Instead of adding yet another single-use callback shuffle things
> > around:
> > - Output handling code is responsible to reset/init all state on its
> >   own at driver load time.
> > - We call the reset functions much earlier, before we start using any
> >   of the modeset code.
> >
> > Compared to Paulo's new ->resume callback the only difference in
> > placement is that ->reset is still called without dev->struct_mutex
> > held. Which is imo a feature.
> >
> > v2: Rebase on top of the now merge dinq.
> >
> > Cc: Paulo Zanoni <przanoni@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Yeah, now I can use it on the eDP patch.
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch