From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/2] drm/i915: drop the i915.fbpercrtc module parameter Date: Tue, 21 Jan 2014 10:28:22 +0100 Message-ID: <20140121092822.GL15089@phenom.ffwll.local> References: <20140107075546.GE4770@phenom.ffwll.local> <1390296265-23565-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id BDBF2FAFCD for ; Tue, 21 Jan 2014 01:28:26 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e49so4008190eek.28 for ; Tue, 21 Jan 2014 01:28:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1390296265-23565-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 21, 2014 at 11:24:24AM +0200, Jani Nikula wrote: > It's unused, and nowadays specifying unknown parameters no longer > prevents modules from being loaded. > > Signed-off-by: Jani Nikula Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_drv.c | 3 --- > drivers/gpu/drm/i915/i915_drv.h | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 62c0f16b869d..a543667140fa 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -44,9 +44,6 @@ MODULE_PARM_DESC(modeset, > "Use kernel modesetting [KMS] (0=DRM_I915_KMS from .config, " > "1=on, -1=force vga console preference [default])"); > > -unsigned int i915_fbpercrtc __always_unused = 0; > -module_param_named(fbpercrtc, i915_fbpercrtc, int, 0400); > - > int i915_panel_ignore_lid __read_mostly = 1; > module_param_named(panel_ignore_lid, i915_panel_ignore_lid, int, 0600); > MODULE_PARM_DESC(panel_ignore_lid, > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index f888fea9cb5d..56c720b789bc 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1896,7 +1896,6 @@ struct drm_i915_file_private { > > extern const struct drm_ioctl_desc i915_ioctls[]; > extern int i915_max_ioctl; > -extern unsigned int i915_fbpercrtc __always_unused; > extern int i915_panel_ignore_lid __read_mostly; > extern unsigned int i915_powersave __read_mostly; > extern int i915_semaphores __read_mostly; > -- > 1.7.9.5 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch