From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order Date: Tue, 21 Jan 2014 11:17:51 +0000 Message-ID: <20140121111751.GD8968@strange.amr.corp.intel.com> References: <1390233152-2913-1-git-send-email-damien.lespiau@intel.com> <1390233152-2913-4-git-send-email-damien.lespiau@intel.com> <8761pd7ik1.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 4238EFB374 for ; Tue, 21 Jan 2014 03:18:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <8761pd7ik1.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 21, 2014 at 12:09:18PM +0200, Jani Nikula wrote: > On Mon, 20 Jan 2014, Damien Lespiau wrote: > > So it's easier to compare what we program with the documentation, not > > having to jump at all. > > This could be squashed into the previous patch just as well, but either > way, I think it's a bit better to have separate patches to factor out code, and modify it. It generates easier diffs to review, rather than having one moving and changing the code at the same time. -- Damien