From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send Date: Tue, 21 Jan 2014 11:59:27 +0000 Message-ID: <20140121115927.GE8968@strange.amr.corp.intel.com> References: <1390233152-2913-1-git-send-email-damien.lespiau@intel.com> <1390233152-2913-3-git-send-email-damien.lespiau@intel.com> <878uu97in8.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 40D51105851 for ; Tue, 21 Jan 2014 03:59:30 -0800 (PST) Content-Disposition: inline In-Reply-To: <878uu97in8.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 21, 2014 at 12:07:23PM +0200, Jani Nikula wrote: > > On Mon, 20 Jan 2014, Damien Lespiau wrote: > > Also, move that computation outside of the for loop that tries 5 times, > > this value doesn't change between tries. > > Some general bikeshedding... > > I really wish everyone would write commit messages that work independent > of the patch subject. Just like a newspaper article should make sense > and tell a story also in the absence of a headline. Will keep this in mind next time (one could argue we're in deep bikeshedding water here!). -- Damien