From: Daniel Vetter <daniel@ffwll.ch>
To: "Bloomfield, Jon" <jon.bloomfield@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Repeat evictions whilst pageflip completions are outstanding
Date: Tue, 21 Jan 2014 13:19:08 +0100 [thread overview]
Message-ID: <20140121121908.GR15089@phenom.ffwll.local> (raw)
In-Reply-To: <AD48BB7FB99B174FBCC69E228F58B3B60157514D@IRSMSX103.ger.corp.intel.com>
On Tue, Jan 21, 2014 at 11:03:43AM +0000, Bloomfield, Jon wrote:
> > From: intel-gfx-bounces@lists.freedesktop.org [mailto:intel-gfx-
> > bounces@lists.freedesktop.org] On Behalf Of Chris Wilson
> > Sent: Monday, January 20, 2014 10:18 AM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Repeat evictions whilst pageflip
> > completions are outstanding
> >
> > Since an old pageflip will keep its scanout buffer object pinned until it has
> > executed its unpin task on the common workqueue, we can clog up our
> > GGTT with stale pinned objects. As we cannot flush those workqueues
> > without dropping our locks, we have to resort to falling back to userspace
> > and telling them to repeat the operation in order to have a chance to run our
> > workqueues and free up the required memory. If we fail, then we are forced
> > to report ENOSPC back to userspace causing the operation to fail and best-
> > case scenario is that it introduces temporary corruption.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Jon Bloomfield <jon.bloomfield@intel.com>
Both merged, with some frobbery to make the 2nd patch apply.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-21 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 21:20 [PATCH] drm/i915: Wait for completion of pending flips when starved of fences Chris Wilson
2014-01-19 21:55 ` Daniel Vetter
2014-01-20 9:49 ` Chris Wilson
2014-01-20 10:17 ` [PATCH 1/2] " Chris Wilson
2014-01-20 10:17 ` [PATCH 2/2] drm/i915: Repeat evictions whilst pageflip completions are outstanding Chris Wilson
2014-01-21 11:03 ` Bloomfield, Jon
2014-01-21 12:19 ` Daniel Vetter [this message]
2014-01-20 20:30 ` [PATCH 1/2] drm/i915: Wait for completion of pending flips when starved of fences Chris Wilson
2014-01-21 9:32 ` Daniel Vetter
2014-01-21 9:37 ` Chris Wilson
2014-01-21 11:03 ` Bloomfield, Jon
2014-01-20 10:37 ` [PATCH] " Daniel Vetter
2014-01-20 10:44 ` Chris Wilson
2014-01-20 16:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121121908.GR15089@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jon.bloomfield@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox