From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH V2] drm/i915: (VLV2) Fix the hotplug detection bits Date: Tue, 21 Jan 2014 20:12:13 +0200 Message-ID: <20140121181213.GH9454@intel.com> References: <1390322330-6486-1-git-send-email-tprevite@gmail.com> <1390324951-6711-1-git-send-email-tprevite@gmail.com> <20140121174554.GC9772@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A734FB27E for ; Tue, 21 Jan 2014 10:12:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140121174554.GC9772@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 21, 2014 at 06:45:54PM +0100, Daniel Vetter wrote: > On Tue, Jan 21, 2014 at 10:22:31AM -0700, Todd Previte wrote: > > These bits are in reverse order in the header from those defined in > > the specification. Change the bit positions for ports B and D to > > correctly match the spec. > > = > > - Added sign-off > > = > > Signed-off-by: Todd Previte > > = > > --- > > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i91= 5_reg.h > > index 10ecf90..2d77b51 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -2083,9 +2083,9 @@ > > * Please check the detailed lore in the commit message for for experi= mental > > * evidence. > > */ > > -#define PORTD_HOTPLUG_LIVE_STATUS (1 << 29) > > +#define PORTD_HOTPLUG_LIVE_STATUS (1 << 27) > > #define PORTC_HOTPLUG_LIVE_STATUS (1 << 28) > > -#define PORTB_HOTPLUG_LIVE_STATUS (1 << 27) > > +#define PORTB_HOTPLUG_LIVE_STATUS (1 << 29) > = > As Jani explained, this will break g4x. And it might very well be that > this particular lie has been carried forward until baytrail, so I think we > must cross check Bspec first with the reality of shipping platforms. FYI I just checked this on Jani's ELK, and it agrees with the spec. Port B is bit 29 and port C is bit 28. Both are HDMI/DVI ports on the board. No DP connectors present unfortunately. Which explains why things work since we don't check the live status on HDMI ports. -- = Ville Syrj=E4l=E4 Intel OTC