public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: IGT conventions
Date: Wed, 22 Jan 2014 21:53:42 +0100	[thread overview]
Message-ID: <20140122205342.GL9772@phenom.ffwll.local> (raw)
In-Reply-To: <20140122204041.GG14542@jeffdesk>

On Wed, Jan 22, 2014 at 02:40:42PM -0600, Jeff McGee wrote:
> There doesn't seem to be anything like the exit handlers for running when
> a subtest exits. I need a failed subtest to be able to cleanup after
> itself to avoid contaminating subsequent subtests. Have I missed something?
> Perhaps this is not a problem when running subtests individually through
> piglit?

Yeah, the exit handlers only clean up when the entire test goes down, not
after each failed subtest. If you want more reliability you need to run
all the subtests individually (and maybe you even need to restart the
machine if something particularly bad happens).

> I guess one simple approach is to wrap igt_assert with the cleanup
> function, like the restore_assert that was originally used in pm_rps.

tbh I'm not sure whether this is worth catering for - imo better to invest
that time into getting a real android/igt testrunner going. For
development you can just run individual subtest only when hacking around,
for regression testing nothing really should fail after all ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2014-01-22 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 23:26 IGT conventions Jeff McGee
2014-01-15 23:55 ` Daniel Vetter
2014-01-16  9:27   ` Daniel Vetter
2014-01-16 16:43     ` Jeff McGee
2014-01-22 20:40       ` Jeff McGee
2014-01-22 20:53         ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140122205342.GL9772@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox