From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm/i915: debugfs: Add support for probing DP sink CRC. Date: Fri, 24 Jan 2014 15:43:58 +0000 Message-ID: <20140124154358.GE3514@strange.config> References: <20140124124020.GC3514@strange.config> <1390577777-3644-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 020ECFB09D for ; Fri, 24 Jan 2014 07:44:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <1390577777-3644-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: Jani Nikula , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jan 24, 2014 at 01:36:17PM -0200, Rodrigo Vivi wrote: > This debugfs interface will allow intel-gpu-tools test case > to verify if screen has been updated properly on cases like PSR. > > v2: Accepted all Daniel's suggestions: > * grab modeset lock > * loop over connector and check DPMS on > * return errors > * use _eDP1 suffix for easy future extension > * don't cache crc_supported neither latest crc > * return crc as a full array and read it at once with aux. > * use 0 to turn TEST_SINK off. > * split the drm_helpers definitions in another patch. > > v3: Accepted 2 Damien's suggestion: remove h from printf hexa > and return ENODEV when eDP not present instead of EAGAIN. > > v4: Accepted 2 Jani' s suggestion: 1 path for unlock and remove > _retry from aux read. > > v5: removing last missing useless _retry (by Damien) > > Cc: Daniel Vetter > Cc: Damien Lespiau > Cc: Jani Nikula > Signed-off-by: Rodrigo Vivi Reviewed-by: Damien Lespiau -- Damien