From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/12] drm/i915: Remove INTEL_INFO()
Date: Sun, 26 Jan 2014 16:09:42 +0100 [thread overview]
Message-ID: <20140126150942.GV9772@phenom.ffwll.local> (raw)
In-Reply-To: <1389035849-20563-6-git-send-email-damien.lespiau@intel.com>
On Mon, Jan 06, 2014 at 07:17:22PM +0000, Damien Lespiau wrote:
> Finally, we reach the goal of the last few patches: the removal of
> INTEL_INFO() in favor of a direct dev_priv usage.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Please pardon my incompetence, but I think I need to pull a heelturn on
this one :(
Apparently product groups noticed again that we have a unified driver
across all platforms ever shipped and they don't like the space overhead
that much. Since the usual approaches of splattering #ifdefs all over the
code or (gasp!) editing all the sources files are complete no-goes for
upstream we need something else. My idea would be to:
- convert all HAS_FOO macros to used INTEL_INFO underneath.
- allow hard-coding of INTEL_INFO structs.
- enable LTE on i915 and let gcc's DCE path take care of all the dead code
removal.
Minimal overhead for upstream, still tidy code and a good chance to get
product groups what they want. But it also means we'll need to keep
INTEL_INFO around, hence why I'll nak patches 1-5.
Patch 6 is merged with Paulo's r-b (it still applied).
Ofc to_i915_dev is still really nice, so can I sheepishly ask you to
resurrect that part of your patches and roll to_i915_dev a bit out over
the tree?
I think I'll owe you a few rounds of your $favourite_beverage the next
time we meet for recompense, maybe at fosdem ...
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-26 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 19:17 Supporting fused display configurations v4 Damien Lespiau
2014-01-06 19:17 ` [PATCH 01/12] drm/i915: Get rid of the INTEL_INFO() usage in i915_drv.h Damien Lespiau
2014-01-06 19:17 ` [PATCH 02/12] drm/i915: Convert a few WM functions to use struct drm_i915_private directly Damien Lespiau
2014-01-06 19:17 ` [PATCH 03/12] drm/i915: Mass replace INTEL_INFO() by dev_priv->info Damien Lespiau
2014-01-06 19:17 ` [PATCH 04/12] drm/i915: Finish replacing INTEL_INFO() by direct dev_priv usage Damien Lespiau
2014-01-06 19:17 ` [PATCH 05/12] drm/i915: Remove INTEL_INFO() Damien Lespiau
2014-01-26 15:09 ` Daniel Vetter [this message]
2014-01-06 19:17 ` [PATCH 06/12] drm/i915: Constify the drm_i915_private pointer a bit more Damien Lespiau
2014-01-06 19:17 ` [PATCH 07/12] drm/i915: Make the intel_device_info structure kept in dev_priv writable Damien Lespiau
2014-01-06 19:17 ` [PATCH 08/12] drm/i915: Move num_plane to the intel_device_info structure Damien Lespiau
2014-01-06 19:17 ` [PATCH 09/12] drm/i915: Consolidate FUSE_STRAP in one set of defines Damien Lespiau
2014-01-06 19:17 ` [PATCH 10/12] drm/i915: Disable display when fused off Damien Lespiau
2014-01-06 19:17 ` [PATCH 11/12] drm/i915: Remove the Quanta special case Damien Lespiau
2014-01-06 19:17 ` [PATCH 12/12] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions Damien Lespiau
2014-01-06 22:05 ` Supporting fused display configurations v4 Paulo Zanoni
2014-01-07 8:07 ` Daniel Vetter
2014-01-07 16:55 ` Damien Lespiau
2014-01-07 8:23 ` Jani Nikula
2014-01-07 10:00 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140126150942.GV9772@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox