From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 00/10] drm/i915: Some less complex FBC fixes
Date: Mon, 27 Jan 2014 11:40:00 +0200
Message-ID: <20140127093959.GN9454@intel.com>
References: <1390488557-16003-1-git-send-email-ville.syrjala@linux.intel.com>
	<20140123194759.GC25529@nuc-i3427.alporthouse.com>
	<20140125195949.GI9772@phenom.ffwll.local>
	<20140126143332.GS9772@phenom.ffwll.local>
	<20140126143542.GT9772@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 68D2BFAA1E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 27 Jan 2014 01:40:06 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140126143542.GT9772@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Jan 26, 2014 at 03:35:42PM +0100, Daniel Vetter wrote:
> On Sun, Jan 26, 2014 at 03:33:32PM +0100, Daniel Vetter wrote:
> > On Sat, Jan 25, 2014 at 08:59:49PM +0100, Daniel Vetter wrote:
> > > On Thu, Jan 23, 2014 at 07:47:59PM +0000, Chris Wilson wrote:
> > > > On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrjala@linux.intel=
.com wrote:
> > > > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > > > =

> > > > > Since fixing the FBC locking is a bigger task that will take a wh=
ile,
> > > > > I decided to pull all the simple fixes from my branch and post th=
em
> > > > > right away.
> > > > > =

> > > > > Some of these I've posted before, some others have seen a bit of =
action
> > > > > by being in a public branch.
> > > > > =

> > > > > The FBC_FENCE_OFF change is just a guess at this point. The odd o=
ffset
> > > > > just caught my eye while reading throguh i915_reg.h.
> > > > =

> > > > I didn't spot anything offensive in the series and each patch only =
does
> > > > what it says on the tin. So I am going to stick my neck out and say
> > > > =

> > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > =

> > > > for the series. Being picky, I guess Fix FBC_FENCE_OFF should only =
be an
> > > > acked-by since we have no way to review it...
> > > =

> > > Entire series merged, and I'll fire up my g4x here to see what happen=
s ;-)
> > =

> > Hm, seems to fail on my g4x when I enable fbc. This is on latest -night=
ly:
> =

> Also, shouldn't we enable fbc now on all gen5+ machines? Or is there still
> something outstanding to fix issues? Atm we only have it enabled on
> haswell :(

The render tracking bits are still broken. And the locking is crap. I
started to fix it for real, but it turned out to be a fair amount of
work, so I figured I'll get back to it after I've cleared out some other
stuff from my desk.

-- =

Ville Syrj=E4l=E4
Intel OTC