From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: read lvds_border_bits state from encoder->get_config Date: Mon, 27 Jan 2014 11:18:20 +0100 Message-ID: <20140127101820.GZ9772@phenom.ffwll.local> References: <1390813231-15476-1-git-send-email-daniel.vetter@ffwll.ch> <1390813231-15476-2-git-send-email-daniel.vetter@ffwll.ch> <20140127095711.GD5258@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140127095711.GD5258@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development , Alan Stern , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 27, 2014 at 09:57:11AM +0000, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 10:00:31AM +0100, Daniel Vetter wrote: > > We seem to get confused when trying to reconstruct this from the pipe > > get_config when reading out pfit state. In our code these two are > > connected, but in the hardware they're not. > > Huh? I think the change is to only read out the border-enable bit when > LVDS is enabled. But that is only a guess at what your intent is here. Yeah, that's the idea. The encoder specific get_config is only called if get_hw_state indicates that the encoder is on. Since we always reset the lvds border bits in the lvds->mode_set callback to the one in the pipe config this should fix the mismatch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch