From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW Date: Mon, 27 Jan 2014 13:54:37 -0800 Message-ID: <20140127215437.GA18251@intel.com> References: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com> <1390616265-4329-5-git-send-email-benjamin.widawsky@intel.com> <20140126114740.GF23557@nuc-i3427.alporthouse.com> <20140126190540.GE894@bwidawsk.net> <20140126195559.GB5258@nuc-i3427.alporthouse.com> <20140126214728.GA1089@bwidawsk.net> <20140127134522.GD2508@nuc-i3427.alporthouse.com> <20140127203108.GC5369@bwidawsk.net> <20140127213104.GF2508@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 57D5FFC3D8 for ; Mon, 27 Jan 2014 13:54:43 -0800 (PST) Received: by mail-pb0-f51.google.com with SMTP id un15so6456243pbc.10 for ; Mon, 27 Jan 2014 13:54:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140127213104.GF2508@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 27, 2014 at 09:31:04PM +0000, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 12:31:08PM -0800, Ben Widawsky wrote: > > The other issue is the existing method doesn't rely as much on proper > > request handling, ie. this could be more resilient to driver bugs. I > > kind of want to keep both... > > Actually I think it is. Part of the process of reading an error dump is > tying together the registers with what is captured. If they are > inconsistent, we know that the driver/capture is buggy. What happens in > the real world is that the GPU executes something completely different > than the batch buffer anyway... > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre Recapping IRC conversation - Chris is sending a patch to fix this problem with his solution. -- Ben Widawsky, Intel Open Source Technology Center