From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 12/28] drm/i915: WaDisableRCCUnitClockGating isn't applicable to IVB Date: Tue, 28 Jan 2014 14:29:41 +0200 Message-ID: <20140128122941.GW9454@intel.com> References: <1390419184-4450-1-git-send-email-ville.syrjala@linux.intel.com> <1390419184-4450-13-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id ECFFEFB7F7 for ; Tue, 28 Jan 2014 04:29:51 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 28, 2014 at 10:18:48AM -0200, Rodrigo Vivi wrote: > For this and next one: According to wa_database this wa seems relevant > for all gt, right? snb is called gt in w/a database language, or did you mean something else? > = > On Wed, Jan 22, 2014 at 5:32 PM, wrote: > > From: Ville Syrj=E4l=E4 > > > > WaDisableRCCUnitClockGating is only relevant for SNB. > > > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/intel_pm.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/int= el_pm.c > > index f40dd1b..1e1c1b1 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -4860,15 +4860,11 @@ static void ivybridge_init_clock_gating(struct = drm_device *dev) > > * Sanctuary and Tropics, and apparently anything else with > > * alpha test or pixel discard. > > * > > - * According to the spec, bit 11 (RCCUNIT) must also be set, > > - * but we didn't debug actual testcases to find it out. > > - * > > * According to the spec, bit 13 (RCZUNIT) must be set on IVB. > > * This implements the WaDisableRCZUnitClockGating:ivb workarou= nd. > > */ > > I915_WRITE(GEN6_UCGCTL2, > > - GEN6_RCZUNIT_CLOCK_GATE_DISABLE | > > - GEN6_RCCUNIT_CLOCK_GATE_DISABLE); > > + GEN6_RCZUNIT_CLOCK_GATE_DISABLE); > > > > /* This is required by WaCatErrorRejectionIssue:ivb */ > > I915_WRITE(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG, > > -- > > 1.8.3.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Rodrigo Vivi > Blog: http://blog.vivi.eng.br -- = Ville Syrj=E4l=E4 Intel OTC