Re: [PATCH 1/1] drm/i915: Enabling plane rotation control through sysfs

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Jan 24, 2014 at 04:24:46PM +0200, Ville Syrjälä wrote:
> On Fri, Jan 24, 2014 at 04:14:10PM +0200, Ville Syrjälä wrote:
> > On Fri, Jan 24, 2014 at 07:18:43PM +0530, sagar.a.kamble@intel.com wrote:
> > > From: Sagar Kamble <sagar.a.kamble@intel.com>
> > > 
> > > This patch enables 180 degree rotation for primary and sprite planes
> > > through sysfs interface.
> > 
> > NAK.
> > 
> > See here for the right apporach:
> > http://lists.freedesktop.org/archives/intel-gfx/2013-September/033951.html
> 
> And BTW if you're really interested in getting this stuff in, we (Daniel
> actually :) need tests in i-g-t. We have the display CRC stuff availalbe,
> so fully automated tests are possible for this stuff. So this is
> definitely one area where we're lacking manpower.
> 
> Some ideas for simple sprite tests:
> - make sure it appears on the right spot on the screen
> - make sure it doesn't appear when off screen
> - make sure it clips correctly when partially off screen
> - repeat everything w/ 180 degree rotation

Chris asked for tiled+sprites tests, so I figured I'd list a few more
things here for posterity:

- test both linear and tiled buffers
- test different pixel formats (dithering, csc, etc. might make this
  a bit tricky)
- test panning inside a larger fb by adjusting the src
  coordinates (overlaps a bit with the clipping tests, but
  I think having separate tests for just panning w/o clipping
  is still good)

-- 
Ville Syrjälä
Intel OTC