From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/1] drm/i915: Enabling plane rotation
 control through sysfs
Date: Tue, 28 Jan 2014 17:59:56 +0200
Message-ID: <20140128155956.GC9454@intel.com>
References: <1390571323-4885-1-git-send-email-sagar.a.kamble@intel.com>
	<20140124141410.GE9454@intel.com> <20140124142446.GF9454@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id B787BFAC45
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 28 Jan 2014 08:00:00 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140124142446.GF9454@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: sagar.a.kamble@intel.com
Cc: intel-gfx@lists.freedesktop.org, Uma Shankar <uma.shankar@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 24, 2014 at 04:24:46PM +0200, Ville Syrj=E4l=E4 wrote:
> On Fri, Jan 24, 2014 at 04:14:10PM +0200, Ville Syrj=E4l=E4 wrote:
> > On Fri, Jan 24, 2014 at 07:18:43PM +0530, sagar.a.kamble@intel.com wrot=
e:
> > > From: Sagar Kamble <sagar.a.kamble@intel.com>
> > > =

> > > This patch enables 180 degree rotation for primary and sprite planes
> > > through sysfs interface.
> > =

> > NAK.
> > =

> > See here for the right apporach:
> > http://lists.freedesktop.org/archives/intel-gfx/2013-September/033951.h=
tml
> =

> And BTW if you're really interested in getting this stuff in, we (Daniel
> actually :) need tests in i-g-t. We have the display CRC stuff availalbe,
> so fully automated tests are possible for this stuff. So this is
> definitely one area where we're lacking manpower.
> =

> Some ideas for simple sprite tests:
> - make sure it appears on the right spot on the screen
> - make sure it doesn't appear when off screen
> - make sure it clips correctly when partially off screen
> - repeat everything w/ 180 degree rotation

Chris asked for tiled+sprites tests, so I figured I'd list a few more
things here for posterity:

- test both linear and tiled buffers
- test different pixel formats (dithering, csc, etc. might make this
  a bit tricky)
- test panning inside a larger fb by adjusting the src
  coordinates (overlaps a bit with the clipping tests, but
  I think having separate tests for just panning w/o clipping
  is still good)

-- =

Ville Syrj=E4l=E4
Intel OTC