From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Add Baytrail PSR Support.
Date: Wed, 29 Jan 2014 13:27:55 +0000
Message-ID: <20140129132755.GD28110@nuc-i3427.alporthouse.com>
References: <1390938445-4666-1-git-send-email-rodrigo.vivi@gmail.com>
	<1390999674-7982-1-git-send-email-rodrigo.vivi@gmail.com>
	<20140129131251.GA28110@nuc-i3427.alporthouse.com>
	<CABVU7+sniPqtsLYCrVYd0q+80jQVpaaa5WpLs0Si_HeoEpMFYA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 017594368C
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 29 Jan 2014 05:27:58 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CABVU7+sniPqtsLYCrVYd0q+80jQVpaaa5WpLs0Si_HeoEpMFYA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 29, 2014 at 11:24:44AM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 11:12 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
> >> This patch adds PSR Support to Baytrail.
> >>
> >> Baytrail cannot easily detect screen updates and force PSR exit.
> >> So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy
> >> and update to enable it back on next display mark_idle.
> >>
> >> v2: Also inactivate PSR on cursor update.
> >> v3: Inactivate PSR on mark_busy, dset_domain and sw_finish_ioctl, and
> >>     early on page flip besides avoid initializing inactive/active flag
> >>     more than once.
> >> v4: Fix identation issues.
> >> v5: Rebase and add Baytrail per pipe support although leaving PIPE_B
> >>     support disabled by for now since it isn't working properly yet.
> >> v6: Removing forgotten comment and useless clkgating definition.
> >
> > Not set-domain. This is semantically a flush and so should be after the
> > damage is done.
> 
> Yep, I semantically I agree, but if we let to inactivate psr after
> damage is done we will miss screen updates.
> This was the safest way to get psr enabled and fully working and
> passing crc tests.
> If you have another place to suggest i'd be glad in do some tests
> here, but for now this is the more stable place I know about.

It's the test that are at fault here for not following the established
ABI imo.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre